HuaHuaY commented on code in PR #54840:
URL: https://github.com/apache/arrow/pull/54840#discussion_r4476207436
##########
cpp/src/arrow/dataset/scanner.h:
##########
@@ -110,6 +110,9 @@ struct ARROW_DS_EXPORT ScanOptions {
/// If null, the global CPU executor will be used
///
/// Note: The Executor will be ignored if use_threads is set to false
+ ///
Review Comment:
```suggestion
```
Minor point: Based on the comments in the surrounding code, shouldn't there
be no empty line between the two `Note:` entries?
##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -1161,7 +1177,7 @@ Result<std::unique_ptr<RecordBatchReader>>
FileReaderImpl::GetRecordBatchReader(
// `this` is a non-owning pointer so we are relying on the parent FileReader
outliving
// this RecordBatchReader.
::arrow::Iterator<RecordBatchIterator> batches =
::arrow::MakeFunctionIterator(
- [readers, batch_schema, num_rows,
+ [readers, batch_schema, num_rows, cpu_executor, use_threads,
Review Comment:
I think the definition of `use_threads` could be placed inside the lambda,
which would avoid having to capture an extra parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
