Jefffrey commented on PR #12010: URL: https://github.com/apache/arrow-rs/pull/12010#issuecomment-6651100601
> This PR is good, but it's not a fix for the issue I reported. > > > ...and a release build has undefined behaviour. > > IIRC, the behavior is defined: it's a panic. It can't be UB because that would be a security hole. We either fix by realigning the buffers or panic. Letting unaligned buffers enter a system will cause problems since Rust code assumes alignment. @felipecrv could you clarify what is needed to close the issue? per https://github.com/apache/arrow-rs/pull/10030 (also linked in PR body), unaligned buffers are automatically aligned, so this PR is just a bug fix for cases where we can still panic on unaligned inputs. once we shore up this hole (and assuming no other bugs), the ffi functions should be able to take unaligned input safely without error/panic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
