Jefffrey commented on code in PR #12029:
URL: https://github.com/apache/arrow-rs/pull/12029#discussion_r4490848918
##########
arrow-arith/src/numeric.rs:
##########
@@ -790,8 +790,11 @@ fn interval_mul_f64(
let month_remainder_days = month_remainder
.to_i32()
.ok_or_else(|| overflow("month remainder"))?;
- let mut seconds_remainder =
- timestamp_round((days_product.fract() + month_remainder.fract()) *
SECONDS_PER_DAY);
+ // Same order as DuckDB; regrouping the terms (e.g. via `fract()`) can
change the last ns.
Review Comment:
```suggestion
// Same order of operations as DuckDB; float arithmetic isn't
associative and we're aiming
// to replicate DuckDB accuracy
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
