ump45nose commented on PR #1379:
URL: https://github.com/apache/arrow-java/pull/1379#issuecomment-6679536438

   Addressed @jbonofre's review in edf274a:
   
   - `Types.NULL.getNewVector` now uses `new NullVector(field)` so FieldType 
(nullability + metadata) is kept through `Field.createVector` / `addOrGet`.
   - `StructWriters` NULL case uses `child.getFieldType()`.
   - Tests now use a non-nullable Null child with metadata and assert field 
equality against the input `structField` / `nullField`.
   
   Local: `mvn -pl vector -am test -Dtest=TestStructVector` (netty + unsafe) — 
15/15 pass.
   
   AI-assisted reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to