Awesome06 commented on PR #55425: URL: https://github.com/apache/arrow/pull/55425#issuecomment-6702867192
I updated the earlier benchmark table with the OG baseline (cast + comparison). Regarding feedback for this PR: 1. Confirming whether Option A is preferred over Option B, given the sampling overhead on smaller batches (< 4,096 rows) and branching complexity. 2. Checking for any edge-case oversights or wrong assumptions in the implementation (`EqualBinaryViewString`, scalar register-pinning). 3. Reviewing whether the test coverage (boundary lengths, prefix collisions, embedded nulls, asymmetric slices) is thorough enough or if additional cases should be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
