EaswarKilari opened a new pull request, #12119: URL: https://github.com/apache/arrow-rs/pull/12119
# Which issue does this PR close? - Part of #7044. # Rationale for this change A few `build_unchecked` calls in the parquet array readers had no comment explaining why they're safe. # What changes are included in this PR? - Added `SAFETY` comments in the list, fixed size list and fixed len byte array readers. - In the fixed len byte array reader, the buffer length check was a `debug_assert`, so it's now a real check that returns an error in release builds too. I left `OffsetBuffer::into_array` out for now, since #11144 is fixing the UTF-8 issue there (#11140). Happy to add the comment once that's merged. # Are these changes tested? Covered by existing tests. The new check shouldn't trigger for valid files. # Are there any significant user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
