viirya commented on PR #12046: URL: https://github.com/apache/arrow-rs/pull/12046#issuecomment-6724898528
Pushed a simplification in 025533769. Writing the offsets through a raw pointer added a second set of `set_len` calls and the requirement to keep the two buffers' lengths in step, which is what the negative key issue tripped over. Offsets are back to `Vec::push`, so only the values are written through a raw pointer. Against the previous revision, this gives up the ~4% gain for 18-19 byte values on Linux (now 0%) and takes 8 byte values from about -28% to -22%. 48 byte values stay at -8%, and macOS moves from about -52% to -48% for 18-19 bytes. The tables in the description are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
