thisisnic commented on issue #55454: URL: https://github.com/apache/arrow/issues/55454#issuecomment-6743408355
I got Claude to check for other dependencies that could fail the same way: required unconditionally by the C++ build and downloaded at build time, so `turn_off_all_optional_features()` in `r/tools/nixlibs.R` can't avoid them. It found one more: xsimd. Only two `resolve_dependency()` calls in `ThirdpartyToolchain.cmake` sit outside any `ARROW_*` gate, xsimd (https://github.com/apache/arrow/blob/87eb47ece85e3d1b3ec4cf5bf2e0e7e4ac8ed08f/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2947) and uriparser (https://github.com/apache/arrow/blob/87eb47ece85e3d1b3ec4cf5bf2e0e7e4ac8ed08f/cpp/cmake_modules/ThirdpartyToolchain.cmake#L3296). xsimd became mandatory in #49940 (25.0.0), which removed the `ARROW_USE_XSIMD` gate, so the `-DARROW_SIMD_LEVEL=NONE` flags the R fallback passes (https://github.com/apache/arrow/blob/87eb47ece85e3d1b3ec4cf5bf2e0e7e4ac8ed08f/r/tools/nixlibs.R#L823-L828) no longer disable anything. Without network or a system xsimd >= 14.2.0 the fallback fails on xsimd before it reaches uriparser, so we might want a fix here to cover both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
