AlenkaF commented on PR #55264: URL: https://github.com/apache/arrow/pull/55264#issuecomment-6737042623
I have answered review comments from @joris to my best capabilities. On some comments I have pinged others, some I left unanswered (connected to array.pyi, pyarrow tests and type checking / annotation setup). @tadeja I have checked the table.pyi changes and tests, all look good to me: most constructors like chunked_array and from_arrays end up using arrays() method which I missed, thanks! I do have one general question that came to mind when looking at the changes pushed for table.pyi: Array/ChunkedArray are already covered by `Iterable[Any]` and the protocols, so adding them to stubs isn't needed to pass type checkers. But should we still list them explicitly? They're the most common inputs and listing them makes it clearer to users when in IDE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
