jaideeppyne commented on PR #11136: URL: https://github.com/apache/arrow-rs/pull/11136#issuecomment-6745011195
@alamb thanks for the review. 0e75fbd addresses all four comments, with replies inline: - The malformed 487 byte file is checked in and read directly. - The column reader unit test is removed; existing end to end tests already cover nullable V1 pages. - Both BYTE_STREAM_SPLIT decoders treat the page value count as an upper bound and reject a page with more encoded values than declared. Strict equality would break nullable V1 pages, where the count includes nulls. The branch also merges current `main` (30c5c32), so CI runs the current workflow. Locally `cargo test -p parquet --lib` (1511 passed), `cargo test -p parquet --test arrow_reader` (147 passed), `cargo clippy -p parquet --all-targets --all-features -- -D warnings` and `cargo fmt` are clean. Prepared with AI assistance. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
