Copilot commented on code in PR #54886:
URL: https://github.com/apache/arrow/pull/54886#discussion_r4511743787
##########
cpp/build-support/fuzzing/generate_corpuses.sh:
##########
@@ -90,3 +90,9 @@ cp "${ARROW_ROOT}"/testing/data/csv/*.csv "${CORPUS_DIR}"
# Add examples from Pandas test suite
find "${PANDAS_DIR}/" -name "*.csv" -exec cp --backup=numbered '{}'
"${CORPUS_DIR}" \;
"${ARROW_CPP}/build-support/fuzzing/pack_corpus.py" "${CORPUS_DIR}"
"${OUT}/arrow-csv-fuzz_seed_corpus.zip"
+
+# JSON reader
+
+rm -rf "${CORPUS_DIR}"
+"${OUT}/arrow-json-generate-fuzz-corpus" "${CORPUS_DIR}"
Review Comment:
A clean `cmake --preset=fuzzing` build leaves `ARROW_JSON` disabled
(`cpp/CMakePresets.json:455–477`), so it never builds this executable. This
unconditional invocation then makes `generate_corpuses.sh` exit with “No such
file or directory” under `set -e`. Enable JSON in the fuzzing preset, and guard
this section for builds that intentionally disable JSON support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
