hcrosse commented on code in PR #1485:
URL: https://github.com/apache/arrow-go/pull/1485#discussion_r4515590636
##########
arrow/compute/exprs/exec.go:
##########
@@ -117,11 +118,11 @@ func makeExecBatch(ctx context.Context, schema
*arrow.Schema, partial compute.Da
// type. for now we'll cast this
val, err = val.CastTo(field.Type)
if err != nil {
- return compute.ExecBatch{}, err
+ return out, err
Review Comment:
Thanks for the repro. `TestMakeExecBatchErrorKeepsNestedStructInput` covers
your list case and a binary field, and checks that the input survives the cast
error and releases cleanly.
##########
arrow/compute/exprs/exec.go:
##########
@@ -117,11 +118,11 @@ func makeExecBatch(ctx context.Context, schema
*arrow.Schema, partial compute.Da
// type. for now we'll cast this
val, err = val.CastTo(field.Type)
if err != nil {
- return compute.ExecBatch{}, err
+ return out, err
Review Comment:
https://github.com/apache/arrow-go/pull/1474 adds `Retain` to
`scalar.Struct` and `scalar.RunEndEncoded`, and this branch now includes it.
`TestExecuteFieldRefNullStructSurvivesBatch` covers the returned null struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
