justinli500 commented on code in PR #49855:
URL: https://github.com/apache/arrow/pull/49855#discussion_r4520951526
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -130,6 +130,8 @@ parquet::ArrowReaderProperties MakeArrowReaderProperties(
// Must be set here since the sync ScanTask handles pre-buffering itself
arrow_properties.set_pre_buffer(
parquet_scan_options.arrow_reader_properties->pre_buffer());
+ // Dataset scans consume each row group once, so cached ranges can be
released.
+ arrow_properties.set_auto_evict_read_cache(true);
Review Comment:
Agreed, I added a Dataset scan test for this. It checks that cached bytes
are released during iteration and that the output is correct. It also fails if
Dataset doesn’t enable eviction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
