wgtmac commented on code in PR #55449:
URL: https://github.com/apache/arrow/pull/55449#discussion_r4527014735
##########
cpp/src/arrow/util/alp/alp_sampler_internal.h:
##########
@@ -46,9 +46,11 @@ class ARROW_EXPORT AlpSampler {
private:
/// Adds one sampling chunk. Only the first
- /// AlpFormatConstants::kDefaultVectorSize elements are examined.
+ /// AlpSamplingOptions::kSampleWindowSize elements are examined.
Review Comment:
These are different quantities: `sampling_window_size` controls the spacing
between sampled chunks, while `kSampleWindowSize` limits the inspected prefix
of each chunk. It is indeed misleading, let me rename `kSampleWindowSize`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
