hcrosse commented on code in PR #1501:
URL: https://github.com/apache/arrow-go/pull/1501#discussion_r4528711487
##########
arrow/compute/scalar_nested.go:
##########
@@ -94,8 +94,7 @@ type listElementFunction struct {
func listElementScalarResultSupported(typ arrow.DataType, nullResult bool)
bool {
switch typ.ID() {
- case arrow.BINARY_VIEW, arrow.STRING_VIEW, arrow.LIST_VIEW,
arrow.LARGE_LIST_VIEW,
- arrow.DECIMAL32, arrow.DECIMAL64:
+ case arrow.BINARY_VIEW, arrow.STRING_VIEW, arrow.LIST_VIEW,
arrow.LARGE_LIST_VIEW:
Review Comment:
I dropped the unreachable edit from
https://github.com/apache/arrow-go/pull/1490, so those lines match main there
and the two PRs no longer conflict. After both land, this PR still removes
`DECIMAL32` and `DECIMAL64`, while `BINARY_VIEW` and `STRING_VIEW` stay
alongside the list views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
