09Catho commented on code in PR #55456:
URL: https://github.com/apache/arrow/pull/55456#discussion_r4533720125
##########
cpp/src/parquet/meson.build:
##########
@@ -147,7 +147,6 @@ install_headers(
'file_writer.h',
'hasher.h',
'index_location.h',
- 'level_comparison.h',
'level_comparison_inc.h',
Review Comment:
It was already in the install list and I only removed the renamed header.
But this points at a real problem with the change. `level_comparison_inc.h` and
`level_conversion_inc.h` are only included from `level_comparison.cc`,
`level_conversion.cc` and `level_conversion_bmi2.cc`, yet both still get
installed: Meson lists them, and CMake's `ARROW_INSTALL_ALL_HEADERS` installs
any header without "internal" in its name. After this PR both include
`parquet/level_comparison_internal.h`, which is no longer installed, so the
installed copies would include a header that isn't there.
I can give both an `_internal` name as well and drop them from the Meson
list. Should I do that here, or keep this PR to `level_comparison.h` and open a
follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
