ump45nose commented on PR #1519:
URL: https://github.com/apache/arrow-go/pull/1519#issuecomment-6817592504
Thanks @zeroshade. Rebased onto current `main` (including #1515 and #1520)
and pushed 793bc05:
- Plain decimal literals are parsed from their digits first, so the hot path
no longer runs `big.ParseFloat` plus a scaling multiply. Magnitude checks use
the digit count after scaling.
- Negative scales now use the same ties-away-from-zero rounding as positive
scales (`"15"` / `"19"` at scale -1 become 2).
- The helper no longer joins `intPart+fracPart` or uses `big.Int.Exp` on the
hot path.
Local `go test` for `./arrow/decimal{,128,256}` and
`./arrow/internal/decimalstr`, plus `./arrow/array`, `./arrow/scalar`,
`./parquet/schema` and `./parquet/variant`, is green.
(AI-assisted reply.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
