agriyakhetarpal commented on PR #47330: URL: https://github.com/apache/arrow/pull/47330#issuecomment-6825844597
> Ah! > > > * I found a bug on the Pyodide side that I am working to prepare a non-arrow reproducer on, which came from investigating `test_read_csv_gil_deadlock`, which is that a side module's weak symbols crash when running `time.sleep()`, when switching stacks with stubs generated from them beneath them. > > Does it crash only for a ` time.sleep()` call or can other operations trigger it as well ? Once you have an upstream issue, could you link it here? Perhaps also a short comment for pytest.mark.threading on `def test_read_csv_gil_deadlock()` It can be anything that uses [`pyodide.ffi.run_sync()`](https://pyodide.org/en/stable/usage/api/python-api/ffi.html#pyodide.ffi.run_sync), like `time.sleep()` here, or `asyncio.run()` or synchronous HTTP with JSPI (which we have enabled). I think Node sockets too. I think it's a bit orthogonal to the test itself, so maybe not worth an inline comment, but I can link it here :) I opened https://github.com/pyodide/pyodide/issues/6551. > > * The testing infrastructure here can rely on `pyodide venv`, which is much simpler. > > Sounds like the `pyodide venv` migration can be done separately. Would you like to open a follow-up issue/PR? Oh, yes, I indeed meant a follow-up PR :) I'm on it and will open one once this one is merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
