etseidl commented on code in PR #11475:
URL: https://github.com/apache/arrow-rs/pull/11475#discussion_r4552289296
##########
parquet/tests/arrow_reader/page_index.rs:
##########
@@ -382,9 +468,9 @@ fn test_page_index_sizes() {
let metadata = reader.finish().unwrap();
assert!(metadata.page_index().is_some());
#[cfg(not(feature = "encryption"))]
- assert_eq!(metadata.memory_size(), 13929);
+ assert_eq!(metadata.memory_size(), 13993);
Review Comment:
Yeah, there's a tradeoff here. We get better sparse memory usage, at the
cost of a bit of overhead on storing all the keys inline. Thankfully that's
offset some by dropping the `Option` wrapper on everything as well.
Down the road we could look at different storage for a fully populated index
if this becomes and issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
