wgtmac commented on code in PR #55449:
URL: https://github.com/apache/arrow/pull/55449#discussion_r4547274314
##########
cpp/src/arrow/util/alp/alp_compression.cc:
##########
@@ -563,17 +573,18 @@ void AlpCompression<T>::Decompress(const
AlpEncodedVectorView<T>& encoded_view,
// Read the exponent/factor once. AlpInfo stores them as uint8_t, which may
// alias the output stores, so reading them inside the loop blocks
vectorization.
const AlpExponentAndFactor exponent_and_factor =
alp_info.GetExponentAndFactor();
+ const auto multipliers = AlpInlines<T>::GetMultipliers(exponent_and_factor);
for (size_t i = 0; i < output.size(); ++i) {
const EncodedUnsigned unfored_value = scratch[i] + frame_of_ref;
const EncodedSigned signed_value =
util::SafeCopy<EncodedSigned>(unfored_value);
- output[i] = AlpInlines<T>::DecodeValue(signed_value, exponent_and_factor);
+ output[i] = AlpInlines<T>::DecodeValue(signed_value, multipliers);
}
Review Comment:
This is on my radar but I think it is better to be a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
