alamb commented on code in PR #12117:
URL: https://github.com/apache/arrow-rs/pull/12117#discussion_r4550918815


##########
parquet/src/file/metadata/mod.rs:
##########
@@ -393,6 +393,18 @@ impl ParquetMetaDataBuilder {
         }
     }
 
+    /// Replaces the file-level key-value metadata.
+    ///
+    /// Pass `None` to remove all entries. This only updates the in-memory 
metadata;
+    /// it does not modify the Parquet file.
+    ///
+    /// Other metadata, including row groups, page indexes, and decryption 
state,
+    /// is preserved. Shared file metadata is cloned before modification.

Review Comment:
   technically speaking I think the shared file metadata is "cloned if 
necessary" (if there there are no other copied it won't be cloned)



##########
parquet/src/file/metadata/mod.rs:
##########
@@ -393,6 +393,18 @@ impl ParquetMetaDataBuilder {
         }
     }
 
+    /// Replaces the file-level key-value metadata.

Review Comment:
   this is consistent with the other APIs to set the metadata like 
https://github.com/apache/arrow-rs/blob/08651bc3d68ceefd900586489a098a7eca770ea6/parquet/src/file/properties.rs#L872-L876



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to