zeroshade commented on PR #1526: URL: https://github.com/apache/arrow-go/pull/1526#issuecomment-6829339940
Thanks, the fix looks right. `go test -asan -short -tags assert,test ./cdata/` passes for me in a `golang:1.26` container with no leak report, and the type check in `releaseExportedArray` uses the exported storage data, so extension-over-view arrays are covered too. I'll merge once CI is green. One optional note, no change needed: an inline-only view now exports a NULL pointer for the sizes buffer. The spec allows that for an empty buffer, but the same function exports other empty buffers as a pointer to `kGoCdataZeroRegion` to be friendly to implementations that don't import NULL properly (apache/arrow#33936). If a consumer turns out to reject the NULL, using that dummy pointer here, and skipping the free for it, would be the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
