hcrosse opened a new pull request, #1545:
URL: https://github.com/apache/arrow-go/pull/1545

   ### Rationale for this change
   
   This follows #1539. `RleBooleanEncoder` has no `Reset` of its own. Calling 
`Reset` keeps the values buffered since the last flush, so the next flush 
encodes them.
   
   ### What changes are included in this PR?
   
   `RleBooleanEncoder.Reset` resets the sink, as `dictEncoder.Reset` does, and 
clears `bufferedValues`, as `FlushValues` does.
   
   ### Are these changes tested?
   
   `TestRleBooleanEncoderResetDropsBufferedValues` puts two values, resets, 
puts one more and flushes. It fails on main, decoding `[true]` instead of 
`[false]`, and passes with this change.
   
   With Go 1.26.10, vet and `go test -race -tags assert,test 
./parquet/internal/encoding/...` passed.
   
   ### Are there any user-facing changes?
   
   No. The encoder is internal, and nothing in arrow-go calls its `Reset`. 
There is no API change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to