raulcd commented on code in PR #55319:
URL: https://github.com/apache/arrow/pull/55319#discussion_r4561494728


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3860,13 +3864,8 @@ function(build_google_cloud_cpp_storage)
   # 141MB -> 79MB
   file(REMOVE_RECURSE "${google_cloud_cpp_SOURCE_DIR}/ci")
 
-  list(PREPEND
-       ARROW_BUNDLED_STATIC_LIBS
-       google-cloud-cpp::storage
-       google-cloud-cpp::rest_internal
-       google-cloud-cpp::common)
-  set(ARROW_BUNDLED_STATIC_LIBS
-      ${ARROW_BUNDLED_STATIC_LIBS}
+  set(ARROW_GCS_BUNDLED_STATIC_LIBS
+      google-cloud-cpp::storage google-cloud-cpp::rest_internal 
google-cloud-cpp::common

Review Comment:
   ok, as this is green and fixes a real issue I think we should merge. We 
should probably create `ARROW_S3_BUNDLED_STATIC_LIBS` as this might be just 
coincidence that is not currently failing but we can do that afterwards.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to