Dricmoy opened a new pull request, #55600:
URL: https://github.com/apache/arrow/pull/55600

   ### Rationale for this change
   
   `strptime` never uses `%Z` to set the result's time zone or adjust the 
parsed time, and what `%Z` accepts depends on the platform's `strptime`:
   
   - Linux (glibc): any word is consumed and ignored, so `"2022-03-05 09:00:00 
blabla"` parses.
   - macOS: only `GMT` or the local time zone abbreviation is accepted.
   - Windows (vendored musl `strptime`): `%Z` isn't supported, so parsing fails.
   
   This picks up #40186, which stalled on wording. "Ignores any string" is only 
true on Linux, so the note describes the platform dependence instead.
   
   ### What changes are included in this PR?
   
   A note on `%Z` in the `strptime` function doc (which the Python docstring is 
generated from) and in the C++ compute docs table.
   
   ### Are these changes tested?
   
   Docs only. I checked the behavior with pyarrow 26.0.1 on macOS, in glibc's 
`time/strptime_l.c`, and in `cpp/src/arrow/vendored/musl/strptime.c`. 
clang-format passes and `scalar_temporal_unary.cc` compiles.
   
   ### Are there any user-facing changes?
   
   Documentation only.
   
   ### Was AI used for this PR?
   
   In accordance to the [AI generation 
guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code),
 please disclose below whether and how AI was used in this PR.
   
   Yes. Claude checked the behavior on each platform and wrote the change and 
this description. I reviewed it and take responsibility for the contribution.
   
   **PR code and description written by:**
   
   - [ ] Human
   - [x] AI
   
   **Reviewed before submission by:**
   
   - [x] Human
   - [x] AI
   - [ ] Not reviewed
   
   * GitHub Issue: #31315
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] GH-31315: [C++][Docs] Doc... Dricmoy (via GitHub) via github

Reply via email to