filippoGRiva opened a new pull request, #907:
URL: https://github.com/apache/arrow-rs-object-store/pull/907
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #877.
# Rationale for this change
`list_request` signed its requests without the `ClientOptions` default
headers, causing the error described in the issue when an `x-amz-*` default
header is set.
I checked other PRs and #883 proposed the same fix and was closed for
non-technical reasons.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
- Make `list_request` add the default headers before signing, as the other
paths do.
- Add `test_default_headers_signed_list_request`, following the existing
pattern of the other tests.
With the reproduction from the issue, the LIST request changes from
```
GET /bucket?list-type=2&prefix=p%2F HTTP/1.1
header sent: true, in SignedHeaders: false
```
to
```
GET /bucket?list-type=2&prefix=p%2F HTTP/1.1
header sent: true, in SignedHeaders: true
```
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
No API changes. List requests now sign the configured default headers.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
Disclaimer: I used Claude Fable 5.2 for the tests and the fix. I reviewed
the code (it's a small change), ran the tests myself and wrote this PR summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]