zeroshade commented on issue #1548: URL: https://github.com/apache/arrow-go/issues/1548#issuecomment-6929453431
Thanks for the benchmark and confirmation that arrow-go isn't the bottleneck. Looks like a very good result and report. > We also found a documentation/implementation ownership mismatch in the pinned version: ExportRecordReader's comment says caller Release is unnecessary, but exportStream retains its own producer reference and stream release drops that retained reference. Our counted-reader and checked-allocator tests balance only when the caller also releases its original reference; a private omitted-original-Release negative control fails both assertions. The actual Redis ADBC exporter uses a separate balanced custom path, so this is not evidence of a driver leak. Is clarification of that comment appropriate here, or would you prefer a separate issue/PR? Clarification of the comment would definitely be appropriate, you don't need a separate issue for it, you can create a PR that just references this issue. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
