AmanBoronbaev opened a new pull request, #12286: URL: https://github.com/apache/arrow-rs/pull/12286
# Which issue does this PR close? Closes #5335. # Rationale for this change Arrow time types cannot represent leap seconds. Parsing `23:59:60` currently produces a value outside the permitted time-of-day range, while `08:08:60` silently becomes the following minute. # What changes are included in this PR? Reject second `60` in the time parser and reject Chrono's leap-second representation when parsing with an explicit format. Document this behavior on `string_to_time_nanoseconds`. # Are these changes tested? Regression tests cover all four Time32/Time64 units, midnight and the last representable instant of the day, fractional leap seconds, AM/PM, surrounding whitespace, and explicit formats. The string-cast tests cover null-on-failure and strict errors for Utf8, LargeUtf8, and Utf8View inputs. The updated regression cases fail on the original implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
