SAY-5 commented on PR #49832: URL: https://github.com/apache/arrow/pull/49832#issuecomment-6933227331
@pitrou reworked it so FromString only rejects actual wraparound: ShiftAndAdd now reports a carry out of the top word, and magnitudes past the signed range (above 2^127-1, or 2^127 for negatives, same idea for 256) are rejected. The 39 digit gold values fit in 128 bits so they parse as before, and the earlier test edits are reverted in favor of enabling the commented out overflow cases in FromStringLimits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
