pitrou commented on code in PR #55647:
URL: https://github.com/apache/arrow/pull/55647#discussion_r4599422780


##########
cpp/src/parquet/metadata.cc:
##########
@@ -2107,7 +2107,7 @@ class FileMetaDataBuilder::FileMetaDataBuilderImpl {
       total_rows += row_group.num_rows;
     }
     metadata_->__set_num_rows(total_rows);
-    metadata_->__set_row_groups(row_groups_);
+    metadata_->row_groups = std::move(row_groups_);

Review Comment:
   This assumes that `FileMetaDataBuilder` is never reused, are we sure that is 
the case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to