zeroshade commented on PR #1399: URL: https://github.com/apache/arrow-go/pull/1399#issuecomment-6953482952
> Keep existing execution functions and add new ones for each major version. For example, keep ExecuteScalarExpression accepting v8 expressions and add ExecuteScalarExpressionV9 for v9. We'd maintain some duplicate code, but users could upgrade when they're ready. Iceberg already builds its own expressions, so we wouldn't need to duplicate Arrow's builders for this use case. I like this idea, though perhaps we can come up with a better name than just tacking `V9` onto it :smile: > Move the Arrow/Substrait code into its own independently versioned module. We'd still have breaking changes, but they wouldn't force a major release of all of Arrow. This might be the better future-looking option though, though we wouldn't move the existing code. Instead we'd deprecate the current ones (to be removed at the next major version release) but this would enable better APIs and avoid requiring major version releases for Arrow itself. > It would also mean keeping dependencies on multiple substrait-go major versions rather than replacing the old one with the new one. While this would make development harder, the Go compiler should be able to drop the unused substrait-go major versions if a dependency is only using one of them instead of both. It might be best to start with option 1 so we can solve the current issue, and then start working on Option 2 and creating a separately versioned Arrow/Substrait module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
