hcrosse opened a new pull request, #1595:
URL: https://github.com/apache/arrow-go/pull/1595

   ### Rationale for this change
   
   Since #1586, `ListElementRef` selects an element per row from list arrays. 
It still rejects `list_view` and `large_list_view` arrays, although 
`compute.ListElement` supports them.
   
   ### What changes are included in this PR?
   
   `arrayStep` passes both types to `compute.ListElement`, which selects an 
element using each row's offset and size. The scalar path is unchanged.
   
   ### Are these changes tested?
   
   I added `list view out of order and overlapping`, `list view sliced` and 
`error past the end of one list view` rows in `TestListElementRefPerRow`, plus 
their `large_list_view` equivalents. The sliced rows include a null, and the 
error rows ask for a child value that exists but lies outside the row's view. 
All six fail on main with the type rejection and pass with this change. The 
nine existing subtests pass on both.
   
   On macOS arm64 with Go 1.26.10, `go test -race -tags assert 
./arrow/compute/exprs/...` and `golangci-lint` 2.13.2 on 
`./arrow/compute/exprs/...` passed.
   
   ### Are there any user-facing changes?
   
   Yes. `ListElementRef` can select an element per row from `list_view` and 
`large_list_view` arrays. There is no API change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to