lriggs commented on code in PR #55608:
URL: https://github.com/apache/arrow/pull/55608#discussion_r4604934616
##########
cpp/src/gandiva/expression_cache_key.h:
##########
@@ -19,17 +19,295 @@
#include <stddef.h>
+#include <algorithm>
+#include <string>
#include <thread>
+#include <type_traits>
+#include <unordered_map>
+#include <vector>
#include "arrow/util/hash_util.h"
#include "gandiva/arrow.h"
#include "gandiva/configuration.h"
#include "gandiva/expression.h"
+#include "gandiva/node.h"
#include "gandiva/selection_vector.h"
#include "gandiva/visibility.h"
namespace gandiva {
+namespace internal {
Review Comment:
The implementation could move to expression_cache_key.cc in an anonymous
namespace. This would reduce header size and compilation time and is a good
practice.
Most/all of the new includes could go into the cc file instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]