Surajsuthar commented on PR #12293:
URL: https://github.com/apache/arrow-rs/pull/12293#issuecomment-6969801023

   > `FixedSizeBinaryDictionaryBuilder::{append, append_n}` still use the 
truncating `value.as_ref().len() as i32` check. With a length that wraps to 
`byte_width`, these checks pass. `get_or_insert_key` then calls the stricter 
`FixedSizeBinaryBuilder::append_value`, discards its error, and appends a key 
for a value that was never inserted. `finish` can therefore build a dictionary 
with an out-of-bounds key. Please use the same `usize` comparison in both 
prechecks
   > 
   > The regression test also allocates 4,294,967,297 bytes in the default 
suite and overflows when run on 32-bit.
   
   @Rich-T-kid  i added prechecks on 
`FixedSizeBinaryDictionaryBuilder::{append, append_n}` and make regression test 
to run on 64-bit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to