Jefffrey commented on code in PR #12219:
URL: https://github.com/apache/arrow-rs/pull/12219#discussion_r4614716065


##########
parquet/src/encodings/encoding/mod.rs:
##########
@@ -577,8 +577,9 @@ impl<T: DataType> DeltaBitPackEncoder<T> {
         }
 
         let mut min_delta = i64::MAX;
-        for i in 0..self.values_in_block {
-            min_delta = cmp::min(min_delta, self.deltas[i]);
+        assert!(self.values_in_block <= self.deltas.len());

Review Comment:
   assert here to preserve the existing behaviour of panicking in case 
`self.values_in_block > self.deltas.len()`
   
   (i dont know if in practice this is possible)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to