ump45nose commented on PR #485: URL: https://github.com/apache/arrow-dotnet/pull/485#issuecomment-6987365343
@CurtHagenlocher All three Copilot points are addressed on the branch: 1. **`Directory.Build.props` `PackagePath`** — the icon and the README both pack with `PackagePath=""` now, so both land at the package root (`d9b24ae`). 2. **`dev/release/verify_rc.sh` loop** — it no longer assumes a 1:1 mapping of `src/*/` directories to packages. It derives the names from `src/*/*.csproj` (`4a6613a`), so `src/README.md` and any directory without a project are skipped. No project sets `PackageId`, so the file name is still the package id. 3. **README example** — the local is `RecordBatch? batch` (`3c9f12c`), with a comment that `ReadNextRecordBatchAsync()` returns null at the end of the file, so pasting the sample into a nullable-enabled project does not warn. Verification I could run here: `bash -n dev/release/verify_rc.sh`, plus a dry run of the new loop over a fixture tree, which emits `nupkg` and `snupkg` names for each project and skips a README file and an empty directory. There is no .NET SDK in this environment, so I could not re-run `dotnet pack`; the last pack check (all seven packages contain `README.md` and `<readme>README.md</readme>`, no new warnings) predates these two commits, which only touch a Markdown snippet and the shell loop. (AI-assisted.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
