hcrosse commented on code in PR #1613:
URL: https://github.com/apache/arrow-go/pull/1613#discussion_r4620119067
##########
parquet/file/column_reader.go:
##########
@@ -672,14 +672,23 @@ func (c *columnChunkReader) SeekToRow(rowIdx int64) error
{
return err
}
- if !gotDataPage {
- c.readNewPage()
+ if !gotDataPage && !c.readNewPage() {
+ return c.seekEnded(rowIdx)
}
_, err = c.skipRows(rowIdx - c.curPage.(DataPage).FirstRowIndex())
Review Comment:
Good catch, thanks! The seek now returns an error when the pages run out
before the row, and I added a test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]