hcrosse opened a new pull request, #1618:
URL: https://github.com/apache/arrow-go/pull/1618

   ### Rationale for this change
   
   `String.ValidateFull` and `LargeString.ValidateFull` panic on intermediate 
offsets past the data buffer instead of returning an error.
   
   ### What changes are included in this PR?
   
   Both methods now compare each offset with the data length after the 
monotonicity check and before slicing for UTF8 validation. The errors use the 
same wording as `Validate`. `Validate` is unchanged.
   
   ### Are these changes tested?
   
   Yes. I added tests for intermediate offsets past the buffer in ordinary and 
sliced string arrays.
   
   ### Are there any user-facing changes?
   
   Yes. Full validation returns errors for string offsets past the data buffer 
instead of panicking. There is no API change.
   
   Closes #1615.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to