zeroshade commented on code in PR #1619:
URL: https://github.com/apache/arrow-go/pull/1619#discussion_r4621028117


##########
arrow/array/validate_test.go:
##########
@@ -408,6 +514,28 @@ func TestStringViewValidate(t *testing.T) {
        })
 }
 
+func TestListViewValidate(t *testing.T) {

Review Comment:
   On 64-bit these tests also pass on main, because nothing overflows there. 
They only catch the bug on 32 bit platforms. The `build-test-386` job in 
`.github/workflows/test.yml` runs `go build ./...` for 386, but it runs `go 
test` only on `./parquet/file/...` and the decimal packages, so nothing in CI 
would catch a regression here.
   
   Running all of `./arrow/array/...` on 386 would fail today: 
`TestTimeJSON/time64[us]` and `time64[ns]` also fail on 386 on main, which is a 
separate bug. Under emulation, every `Validate` test in this package passes on 
386 with this change, so a step like this would cover these tests now:
   
   ```yaml
   - name: Test arrow/array validation for 386
     run: GOARCH=386 go test -run Validate ./arrow/array/...
   ```
   
   The whole package could replace it once the time64 failure is fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to