jhorstmann opened a new pull request #419:
URL: https://github.com/apache/arrow-rs/pull/419
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #391.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The `keys_array` can be a performance problem if used in inner loops and
most usages can be directly replaced by the `keys` method which returns a
reference without any cloning or allocations.
# What changes are included in this PR?
Removed the method and replaced it's usages with the `keys` method.
<!---
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Yes, this is a breaking change.
This is currently a draft because there were actually two usages in the
`cast` kernels that could not be directly replaced. We do not seem to have an
obvious way to get from `&PrimitiveArray<T>` to `ArrayRef`. This transformation
would be much easier if the `PrimitiveArray` itself was cloneable.
<!---
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
