jonkeane commented on a change in pull request #10462:
URL: https://github.com/apache/arrow/pull/10462#discussion_r646594774
##########
File path: dev/archery/archery/crossbow/core.py
##########
@@ -194,7 +194,8 @@ def credentials(self, url, username_from_url,
allowed_types):
print(msg)
raise CrossbowError(msg)
- if allowed_types & pygit2.credentials.GIT_CREDTYPE_USERPASS_PLAINTEXT:
+ if (allowed_types &
+ pygit2.credentials.GIT_CREDENTIAL_USERPASS_PLAINTEXT):
Review comment:
I wish the changelog had a bit more info than the declarative
"deprecated GIT_CREDTYPE.*" and then "Removed deprecated GIT_CREDTYPE_*" to say
_why_ without needing to go digging through git blame to find it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
