n3world commented on a change in pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#discussion_r646666716
##########
File path: cpp/src/arrow/csv/chunker.cc
##########
@@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder {
return Status::OK();
}
- Status FindNth(util::string_view partial, util::string_view block, uint64_t
count,
- int64_t* out_pos, uint64_t* num_found) override {
+ Status FindNth(util::string_view partial, util::string_view block, int64_t
count,
Review comment:
Looking at the csv options there currently is no validation on any of
those values other than asserts. It might make sense to add a options
validation to the ReaderMixin as part of another PR.
Mildly related, I also noticed I probably should have made
`skip_rows_after_names` an `int64_t` to match the type of the variable in the
chunker. Do you want me to make that change quickly or do you want to do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
