nealrichardson commented on pull request #10445:
URL: https://github.com/apache/arrow/pull/10445#issuecomment-858109294
> I've used `arrow.use_altrep` but I can use `arrow.altrep` all the same.
SGTM
>
> I've put `GetBoolOption("arrow.altrep", true)` after the
`array->null_count() == 0` because it's cheaper to call `null_count()`.
That surprises me, I'd expect that checking an R boolean would be faster
than counting nulls in a (potentially long) array.
>
> `GetBoolOption("arrow.altrep", true)` means that this is opt-out, I'm fine
with this but it might be risky.
I think defaulting to ALTREP on is good (particularly if/when we quantify
its benefits) but leaving an escape hatch in case of error is nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
