pitrou commented on a change in pull request #10566:
URL: https://github.com/apache/arrow/pull/10566#discussion_r656064664
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -270,24 +279,29 @@ ParquetFileFormat::ParquetFileFormat(const
parquet::ReaderProperties& reader_pro
}
Result<bool> ParquetFileFormat::IsSupported(const FileSource& source) const {
- try {
- ARROW_ASSIGN_OR_RAISE(auto input, source.Open());
- ARROW_ASSIGN_OR_RAISE(auto parquet_scan_options,
- GetFragmentScanOptions<ParquetFragmentScanOptions>(
- kParquetTypeName, nullptr,
default_fragment_scan_options));
- auto reader = parquet::ParquetFileReader::Open(
- std::move(input), MakeReaderProperties(*this,
parquet_scan_options.get()));
- std::shared_ptr<parquet::FileMetaData> metadata = reader->metadata();
- return metadata != nullptr && metadata->can_decompress();
- } catch (const ::parquet::ParquetInvalidOrCorruptedFileException& e) {
- ARROW_UNUSED(e);
- return false;
- } catch (const ::parquet::ParquetException& e) {
- return Status::IOError("Could not open parquet input source '",
source.path(),
- "': ", e.what());
- }
-
- return true;
+ auto maybe_is_supported = [&]() -> Result<bool> {
Review comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
