lidavidm commented on a change in pull request #10544:
URL: https://github.com/apache/arrow/pull/10544#discussion_r657924667
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -224,19 +228,19 @@ struct Multiply {
static_assert(std::is_same<decltype(int64_t() * int64_t()), int64_t>::value,
"");
static_assert(std::is_same<decltype(uint64_t() * uint64_t()),
uint64_t>::value, "");
- template <typename T>
+ template <typename T, typename Arg0, typename Arg1>
static constexpr enable_if_floating_point<T> Call(KernelContext*, T left, T
right,
Status*) {
return left * right;
}
- template <typename T>
+ template <typename T, typename Arg0, typename Arg1>
static constexpr enable_if_unsigned_integer<T> Call(KernelContext*, T left,
T right,
Status*) {
return left * right;
}
- template <typename T>
+ template <typename T, typename Arg0, typename Arg1>
static constexpr enable_if_signed_integer<T> Call(KernelContext*, T left, T
right,
Status*) {
return to_unsigned(left) * to_unsigned(right);
Review comment:
Thanks for digging into this. I updated the templates here so that the
specialization is called again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
