pitrou commented on a change in pull request #10511:
URL: https://github.com/apache/arrow/pull/10511#discussion_r662187209
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -526,9 +526,70 @@ def call_function(name, args, options=None,
memory_pool=None):
cdef class FunctionOptions(_Weakrefable):
+ __slots__ = () # avoid mistakingly creating attributes
cdef const CFunctionOptions* get_options(self) except NULL:
- raise NotImplementedError("Unimplemented base options")
+ return self.wrapped.get()
+
+ cdef void init(self, unique_ptr[CFunctionOptions] options):
+ self.wrapped = move(options)
+
+ def serialize(self):
+ cdef:
+ CResult[shared_ptr[CBuffer]] res = self.get_options().Serialize()
+ shared_ptr[CBuffer] c_buf = GetResultValue(res)
+ return pyarrow_wrap_buffer(c_buf)
+
+ @staticmethod
+ def deserialize(buf):
+ cdef:
+ shared_ptr[CBuffer] c_buf = pyarrow_unwrap_buffer(buf)
+ CResult[unique_ptr[CFunctionOptions]] maybe_options = \
+ DeserializeFunctionOptions(deref(c_buf))
+ unique_ptr[CFunctionOptions] c_options
+ c_options = move(GetResultValue(move(maybe_options)))
+ type_name = frombytes(c_options.get().options_type().type_name())
+ mapping = {
+ "array_sort": ArraySortOptions,
Review comment:
Is their a reason the `type_name` is different from the C++ class name
(which is the same as the Python class name)? If it was the same, we probably
wouldn't need to hand-maintain this mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
