rok commented on pull request #10610:
URL: https://github.com/apache/arrow/pull/10610#issuecomment-877088851


   > > and how to return NaN when the timestamp is an int64.
   > 
   > I think it should rather be a null instead of NaN (I suppose this is for 
the IGNORE case?), and nulls can be encoded in int64.
   
   Yes I was thinking about the IGNORE case. This should now return nulls but 
zeros are returned. Do we need to switch away from `ScalarUnaryNotNullStateful` 
for this?
   
   > I also think that the output type of the kernel should be timestamp _with_ 
timezone.
   
   Done. I was not sure how to get the timezone into the out type. I've made a 
runtime resolver now.
   
   I'll move this out of draft to invite more discussion :).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to