rok commented on a change in pull request #10647:
URL: https://github.com/apache/arrow/pull/10647#discussion_r670874666
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -178,6 +179,20 @@ class ARROW_EXPORT StrptimeOptions : public
FunctionOptions {
TimeUnit::type unit;
};
+class ARROW_EXPORT StrftimeOptions : public FunctionOptions {
+ public:
+ explicit StrftimeOptions(std::string format, std::string timezone);
+ StrftimeOptions();
+ constexpr static char const kTypeName[] = "StrftimeOptions";
+
+ /// The desired format string.
+ std::string format;
+ /// Timezone to output the time in.
+ std::string timezone;
Review comment:
I'm not sure we can print timezone naive timestamps without
"understanding" them as UTC first anyway (in the `date.h` logic) so I don't
think we can get rid of the overhead. But we can choose to do it with one
kernel or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
