kszucs commented on a change in pull request #10457:
URL: https://github.com/apache/arrow/pull/10457#discussion_r673134382
##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -1427,9 +1428,20 @@ def test_extract_datetime_components():
"2008-12-28",
"2008-12-29",
"2012-01-01 01:02:03"]
+ timezones = ["UTC", "US/Central", "Asia/Kolkata",
+ "Etc/GMT-4", "Etc/GMT+4", "Australia/Broken_Hill"]
+ # Test timezone naive timestamp array
_check_datetime_components(timestamps)
+ # Test timezone aware timestamp array
+ if sys.platform == 'win32':
+ # TODO: We should test on windows once ARROW-13168 is resolved.
+ pytest.skip('Timezone database is not available on Windows yet')
+ else:
+ for timezone in timezones:
+ _check_datetime_components(timestamps, timezone)
Review comment:
@rok seems like the timezone argument is not used within the
`_check_datetime_components` helper, so I think it doesn't have any effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
