seddonm1 commented on pull request #778: URL: https://github.com/apache/arrow-datafusion/pull/778#issuecomment-887855793
@alamb @houqp I have updated the PR with @alamb suggestion of a `join_keys: (Vec<impl Into<Column>>, Vec<impl Into<Column>>)` signature. I think this does make it less ambiguous than previously but does increase the surface area of this PR - so now needs additional scrutiny. Regarding @houqp dataframe suggestion, I am not sure how we proceed; I would expect users of the dataframe API to be much more capable of adapting to logically specifying keys in the 'correct' order vs SQL users who just want it to behave like any other SQL engine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
